Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blip rate of 0 which only plays a single blip sound per message #659

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

Crystalwarrior
Copy link
Contributor

Closes #637

src/courtroom.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment on lines +13 to +14
if (result < 0)
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: statement should be inside braces [readability-braces-around-statements]

Suggested change
if (result < 0)
return 0;
if (result < 0) {
return 0;
}

Copy link
Member

@oldmud0 oldmud0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice you brought the diff down to like 6 lines

@oldmud0 oldmud0 merged commit df1c8cc into master Mar 19, 2022
@in1tiate in1tiate deleted the blip-rate-0 branch July 18, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single-blip blip rate
2 participants